Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c1270da authored by Huazhong Tan's avatar Huazhong Tan Committed by David S. Miller
Browse files

net: hns3: simplify hclge_cmd_csq_clean 



csq is used as a ring buffer, the value of the desc will be replaced
in next use. This patch removes the unnecessary memset, and just
updates the next_to_clean.

Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 043fa454

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c

+5 −16
Original line number Diff line number Diff line
@@ -151,31 +151,20 @@ static int hclge_cmd_csq_clean(struct hclge_hw *hw) 
{

	struct hclge_dev *hdev = container_of(hw, struct hclge_dev, hw);

	struct hclge_cmq_ring *csq = &hw->cmq.csq;

	u16 ntc = csq->next_to_clean;

	struct hclge_desc *desc;

	int clean = 0;

	u32 head;

	int clean;



	desc = &csq->desc[ntc];

	head = hclge_read_dev(hw, HCLGE_NIC_CSQ_HEAD_REG);

	rmb(); /* Make sure head is ready before touch any data */



	if (!is_valid_csq_clean_head(csq, head)) {

		dev_warn(&hdev->pdev->dev, "wrong head (%d, %d-%d)\n", head,

		dev_warn(&hdev->pdev->dev, "wrong cmd head (%d, %d-%d)\n", head,

			 csq->next_to_use, csq->next_to_clean);

		return 0;

	}



	while (head != ntc) {

		memset(desc, 0, sizeof(*desc));

		ntc++;

		if (ntc == csq->desc_num)

			ntc = 0;

		desc = &csq->desc[ntc];

		clean++;

	}

	csq->next_to_clean = ntc;



	clean = (head - csq->next_to_clean + csq->desc_num) % csq->desc_num;

	csq->next_to_clean = head;

	return clean;

}