Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 043fa454 authored by Huazhong Tan's avatar Huazhong Tan Committed by David S. Miller
Browse files

net: hns3: remove some redundant assignments 



Remove some redundant assignments.
desc->flag = cpu_to_le16(HCLGE_CMD_FLAG_NO_INTR | HCLGE_CMD_FLAG_IN)
has set bit HCLGE_CMD_FLAG_WR to zero, so does others.

Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent eb55323c

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c

+0 −2
Original line number Diff line number Diff line
@@ -110,8 +110,6 @@ void hclge_cmd_setup_basic_desc(struct hclge_desc *desc, 


	if (is_read)

		desc->flag |= cpu_to_le16(HCLGE_CMD_FLAG_WR);

	else

		desc->flag &= cpu_to_le16(~HCLGE_CMD_FLAG_WR);

}



static void hclge_cmd_config_regs(struct hclge_cmq_ring *ring)

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+0 −8
Original line number Diff line number Diff line
@@ -2733,7 +2733,6 @@ int hclge_func_reset_cmd(struct hclge_dev *hdev, int func_id) 
	int ret;



	hclge_cmd_setup_basic_desc(&desc, HCLGE_OPC_CFG_RST_TRIGGER, false);

	hnae_set_bit(req->mac_func_reset, HCLGE_CFG_RESET_MAC_B, 0);

	hnae_set_bit(req->mac_func_reset, HCLGE_CFG_RESET_FUNC_B, 1);

	req->fun_reset_vfid = func_id;
@@ -4264,16 +4263,9 @@ int hclge_add_uc_addr_common(struct hclge_vport *vport, 


	memset(&req, 0, sizeof(req));

	hnae_set_bit(req.flags, HCLGE_MAC_VLAN_BIT0_EN_B, 1);

	hnae_set_bit(req.entry_type, HCLGE_MAC_VLAN_BIT0_EN_B, 0);

	hnae_set_bit(req.entry_type, HCLGE_MAC_VLAN_BIT1_EN_B, 0);

	hnae_set_bit(req.mc_mac_en, HCLGE_MAC_VLAN_BIT0_EN_B, 0);



	hnae_set_bit(egress_port, HCLGE_MAC_EPORT_SW_EN_B, 0);

	hnae_set_bit(egress_port, HCLGE_MAC_EPORT_TYPE_B, 0);

	hnae_set_field(egress_port, HCLGE_MAC_EPORT_VFID_M,

		       HCLGE_MAC_EPORT_VFID_S, vport->vport_id);

	hnae_set_field(egress_port, HCLGE_MAC_EPORT_PFID_M,

		       HCLGE_MAC_EPORT_PFID_S, 0);



	req.egress_port = cpu_to_le16(egress_port);