Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ea88662 authored by Quinn Tran's avatar Quinn Tran Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Fix NULL pointer access due to redundant fc_host_port_name call 



Remove redundant fc_host_port_name calls to prevent early access of
scsi_host->shost_data buffer. This prevent null pointer access.

Following stack trace is seen:

BUG: unable to handle kernel NULL pointer dereference at 00000000000008
IP: qla24xx_report_id_acquisition+0x22d/0x3a0 [qla2xxx]

Cc: <stable@vger.kernel.org> # v4.11+
Signed-off-by: default avatarQuinn Tran <quinn.tran@cavium.com>
Signed-off-by: default avatarHimanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent cb590700

drivers/scsi/qla2xxx/qla_mbx.c

+0 −9
Original line number Diff line number Diff line
@@ -3676,15 +3676,6 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha, 
				qlt_update_host_map(vha, id);

			}



			fc_host_port_name(vha->host) =

			    wwn_to_u64(vha->port_name);



			if (qla_ini_mode_enabled(vha))

				ql_dbg(ql_dbg_mbx, vha, 0x1018,

				    "FA-WWN portname %016llx (%x)\n",

				    fc_host_port_name(vha->host),

				    rptid_entry->vp_status);



			set_bit(REGISTER_FC4_NEEDED, &vha->dpc_flags);

			set_bit(REGISTER_FDMI_NEEDED, &vha->dpc_flags);

		} else {