Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb590700 authored by himanshu.madhani@cavium.com's avatar himanshu.madhani@cavium.com Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Fix recursive loop during target mode configuration for ISP25XX... 

scsi: qla2xxx: Fix recursive loop during target mode configuration for ISP25XX leaving system unresponsive

Following messages are seen into system logs

qla2xxx [0000:09:00.0]-00af:9: Performing ISP error recovery - ha=ffff98315ee30000.
qla2xxx [0000:09:00.0]-504b:9: RISC paused -- HCCR=40, Dumping firmware.
qla2xxx [0000:09:00.0]-d009:9: Firmware has been previously dumped (ffffba488c001000) -- ignoring request.
qla2xxx [0000:09:00.0]-504b:9: RISC paused -- HCCR=40, Dumping firmware.

See Bugzilla for details
https://bugzilla.kernel.org/show_bug.cgi?id=195285



Fixes: d7459527 ("scsi: qla2xxx: Add multiple queue pair functionality.")
Cc: <stable@vger.kernel.org> # v4.10+
Reported-by: default avatarLaurence Oberman <loberman@redhat.com>
Reported-by: default avatarAnthony Bloodoff <anthony.bloodoff@gmail.com>
Tested-by: default avatarLaurence Oberman <loberman@redhat.com>
Tested-by: default avatarAnthony Bloodoff <anthony.bloodoff@gmail.com>
Signed-off-by: default avatarHimanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: default avatarGiridhar Malavali <giridhar.malavali@cavium.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c2dd893a

drivers/scsi/qla2xxx/qla_isr.c

+1 −1
Original line number Diff line number Diff line
@@ -3282,7 +3282,7 @@ qla24xx_enable_msix(struct qla_hw_data *ha, struct rsp_que *rsp) 
	}



	/* Enable MSI-X vector for response queue update for queue 0 */

	if (IS_QLA83XX(ha) || IS_QLA27XX(ha)) {

	if (IS_QLA25XX(ha) || IS_QLA83XX(ha) || IS_QLA27XX(ha)) {

		if (ha->msixbase && ha->mqiobase &&

		    (ha->max_rsp_queues > 1 || ha->max_req_queues > 1 ||

		     ql2xmqsupport))