Commit 06ed7706 authored Oct 16, 2018 by Christophe JAILLET Committed by Greg Kroah-Hartman Dec 01, 2019

wlcore: Fix the return value in case of error in 'wlcore_vendor_cmd_smart_config_start()'



[ Upstream commit 3419348a97bcc256238101129d69b600ceb5cc70 ]

We return 0 unconditionally at the end of
'wlcore_vendor_cmd_smart_config_start()'.
However, 'ret' is set to some error codes in several error handling paths
and we already return some error codes at the beginning of the function.

Return 'ret' instead to propagate the error code.

Fixes: 80ff8063 ("wlcore: handle smart config vendor commands")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c68a4994

drivers/net/wireless/ti/wlcore/vendor_cmd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -70,7 +70,7 @@ wlcore_vendor_cmd_smart_config_start(struct wiphy *wiphy,
		out:
		mutex_unlock(&wl->mutex);

		return 0;
		return ret;
		}

		static int