Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c68a4994 authored by Brian Norris's avatar Brian Norris Committed by Greg Kroah-Hartman
Browse files

ath10k: snoc: fix unbalanced clock error handling 



[ Upstream commit 82e60d920e8ad70cd9a280ab156566755f1fe4aa ]

Similar to regulator error handling, we should only start tearing down
the 'i - 1' clock when clock 'i' fails to enable. Otherwise, we might
end up with an unbalanced clock, where we never successfully enabled the
clock, but we try to disable it anyway.

Fixes: a6a793f9 ("ath10k: vote for hardware resources for WCN3990")
Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent c262dc06

drivers/net/wireless/ath/ath10k/snoc.c

+1 −1
Original line number Diff line number Diff line
@@ -1190,7 +1190,7 @@ static int ath10k_wcn3990_clk_init(struct ath10k *ar) 
	return 0;



err_clock_config:

	for (; i >= 0; i--) {

	for (i = i - 1; i >= 0; i--) {

		clk_info = &ar_snoc->clk[i];



		if (!clk_info->handle)