Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0600d5f1 authored by Hans Verkuil's avatar Hans Verkuil Committed by Greg Kroah-Hartman
Browse files

media: pci: cx23885: replace BUG with error return 



[ Upstream commit 2e1796fd4904fdd6062a8e4589778ea899ea0c8d ]

It was completely unnecessary to use BUG in buffer_prepare().
Just replace it with an error return. This also fixes a smatch warning:

drivers/media/pci/cx23885/cx23885-video.c:422 buffer_prepare() error: uninitialized symbol 'ret'.

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent f844bc3a

drivers/media/pci/cx23885/cx23885-video.c

+1 −1
Original line number Diff line number Diff line
@@ -420,7 +420,7 @@ static int buffer_prepare(struct vb2_buffer *vb) 
				dev->height >> 1);

		break;

	default:

		BUG();

		return -EINVAL; /* should not happen */

	}

	dprintk(2, "[%p/%d] buffer_init - %dx%d %dbpp \"%s\" - dma=0x%08lx\n",

		buf, buf->vb.vb2_buf.index,