Commit f844bc3a authored Jul 20, 2023 by Hans Verkuil Committed by Greg Kroah-Hartman Sep 23, 2023

media: tuners: qt1010: replace BUG_ON with a regular error



[ Upstream commit ee630b29ea44d1851bb6c903f400956604834463 ]

BUG_ON is unnecessary here, and in addition it confuses smatch.
Replacing this with an error return help resolve this smatch
warning:

drivers/media/tuners/qt1010.c:350 qt1010_init() error: buffer overflow 'i2c_data' 34 <= 34

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 5e80c5b5

drivers/media/tuners/qt1010.c

+6 −5

Original line number	Diff line number	Diff line
		@@ -351,8 +351,9 @@ static int qt1010_init(struct dvb_frontend *fe)
		else
		valptr = &tmpval;

		BUG_ON(i >= ARRAY_SIZE(i2c_data) - 1);

		if (i >= ARRAY_SIZE(i2c_data) - 1)
		err = -EIO;
		else
		err = qt1010_init_meas1(priv, i2c_data[i + 1].reg,
		i2c_data[i].reg,
		i2c_data[i].val, valptr);