Commit 01098081 authored May 19, 2017 by Colin Ian King Committed by Chris Wilson May 19, 2017

drm/i915: Check for allocation failure

The memory allocation for C is not being null checked and hence we
could end up with a null pointer dereference. Fix this with a null
pointer check. (I really should have noticed this when I was fixing an
earlier issue.)

Detected by CoverityScan, CID#1436406 ("Dereference null return")

Fixes: 47624cc3 ("drm/i915: Import the kfence selftests for i915_sw_fence")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170519175617.7036-1-colin.king@canonical.com

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

parent 00bd16f2

drivers/gpu/drm/i915/selftests/i915_sw_fence.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -123,6 +123,11 @@ static int test_dag(void *arg)
		}

		C = alloc_fence();
		if (!C) {
		ret = -ENOMEM;
		goto err_B;
		}

		if (i915_sw_fence_await_sw_fence_gfp(B, C, GFP_KERNEL) == -EINVAL) {
		pr_err("invalid cycle detected\n");
		goto err_C;