Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd659f8e authored by Johannes Berg's avatar Johannes Berg Committed by Luca Coelho
Browse files

iwlwifi: mvm: tighten BAID range check 



As pointed out by smatch, checking the BAID for just >= INVALID
is a bad idea since only 32 (IWL_MAX_BAID) actually exist. Check
the range for that and print invalid ones in the warning.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 9b856836

drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c

+1 −1
Original line number Diff line number Diff line
@@ -503,7 +503,7 @@ static void iwl_mvm_del_ba(struct iwl_mvm *mvm, int queue, 
	struct iwl_mvm_reorder_buffer *reorder_buf;

	u8 baid = data->baid;



	if (WARN_ON_ONCE(baid >= IWL_RX_REORDER_DATA_INVALID_BAID))

	if (WARN_ONCE(baid >= IWL_MAX_BAID, "invalid BAID: %x\n", baid))

		return;



	rcu_read_lock();