Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b856836 authored by Johannes Berg's avatar Johannes Berg Committed by Luca Coelho
Browse files

iwlwifi: mvm: remove pointless _bh from spinlock in timer



Inside the reorder timer expire function, there's no point in
disabling BHs since it is in BH context. Remove that.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 723d11a4
Loading
Loading
Loading
Loading
+3 −3
Original line number Diff line number Diff line
@@ -452,10 +452,10 @@ void iwl_mvm_reorder_timer_expired(unsigned long data)
	u16 sn = 0, index = 0;
	bool expired = false;

	spin_lock_bh(&buf->lock);
	spin_lock(&buf->lock);

	if (!buf->num_stored || buf->removed) {
		spin_unlock_bh(&buf->lock);
		spin_unlock(&buf->lock);
		return;
	}

@@ -492,7 +492,7 @@ void iwl_mvm_reorder_timer_expired(unsigned long data)
			  buf->reorder_time[index] +
			  1 + RX_REORDER_BUF_TIMEOUT_MQ);
	}
	spin_unlock_bh(&buf->lock);
	spin_unlock(&buf->lock);
}

static void iwl_mvm_del_ba(struct iwl_mvm *mvm, int queue,