Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed1f0418 authored by Dan Carpenter's avatar Dan Carpenter Committed by Vinod Koul
Browse files

dmaengine: xgene: buffer overflow in xgene_dma_init_channels() 



We put 9 characters into the 8 character name[] array.  Let's make the
array bigger and change the sprintf() to snprintf().

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent d7d8e892

drivers/dma/xgene-dma.c

+2 −2
Original line number Diff line number Diff line
@@ -314,7 +314,7 @@ struct xgene_dma_chan { 
	struct device *dev;

	int id;

	int rx_irq;

	char name[8];

	char name[10];

	spinlock_t lock;

	int pending;

	int max_outstanding;
@@ -1876,7 +1876,7 @@ static void xgene_dma_init_channels(struct xgene_dma *pdma) 
		chan->dev = pdma->dev;

		chan->pdma = pdma;

		chan->id = i;

		sprintf(chan->name, "dmachan%d", chan->id);

		snprintf(chan->name, sizeof(chan->name), "dmachan%d", chan->id);

	}

}