Commit d7d8e892 authored Apr 03, 2015 by Yoshihiro Shimoda Committed by Vinod Koul Apr 17, 2015

dmaengine: usb-dmac: Fix dereferencing freed memory 'desc'



This patch fixes an issue that the usb_dmac_desc_free() is
dereferencing freed memory 'desc' because it uses list_for_each_entry().
This function should use list_for_each_entry_safe().

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 28591dfd

drivers/dma/sh/usb-dmac.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -285,13 +285,13 @@ static int usb_dmac_desc_alloc(struct usb_dmac_chan *chan, unsigned int sg_len,

		static void usb_dmac_desc_free(struct usb_dmac_chan *chan)
		{
		struct usb_dmac_desc *desc;
		struct usb_dmac_desc desc, _desc;
		LIST_HEAD(list);

		list_splice_init(&chan->desc_freed, &list);
		list_splice_init(&chan->desc_got, &list);

		list_for_each_entry(desc, &list, node) {
		list_for_each_entry_safe(desc, _desc, &list, node) {
		list_del(&desc->node);
		kfree(desc);
		}