Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dfd4f0ae authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

[TCP]: Avoid two divides in __tcp_grow_window() 



tcp_win_from_space() being signed, compiler might emit an integer divide
to compute tcp_win_from_space()/2 .

Using right shifts is OK here and less expensive.

Signed-off-by: default avatarEric Dumazet <dada1@cosmosbay.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8beb5c5f

net/ipv4/tcp_input.c

+2 −2
Original line number Diff line number Diff line
@@ -289,8 +289,8 @@ static int __tcp_grow_window(const struct sock *sk, const struct sk_buff *skb) 
{

	struct tcp_sock *tp = tcp_sk(sk);

	/* Optimize this! */

	int truesize = tcp_win_from_space(skb->truesize)/2;

	int window = tcp_win_from_space(sysctl_tcp_rmem[2])/2;

	int truesize = tcp_win_from_space(skb->truesize) >> 1;

	int window = tcp_win_from_space(sysctl_tcp_rmem[2]) >> 1;



	while (tp->rcv_ssthresh <= window) {

		if (truesize <= skb->len)