Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8beb5c5f authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

[TCP]: Avoid a divide in tcp_mtu_probing() 



tcp_mtu_to_mss() being signed, compiler might emit an integer divide
to compute tcp_mtu_to_mss()/2 .

Using a right shift is OK here and less expensive.

Signed-off-by: default avatarEric Dumazet <dada1@cosmosbay.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 829942c1

net/ipv4/tcp_timer.c

+1 −1
Original line number Diff line number Diff line
@@ -125,7 +125,7 @@ static void tcp_mtu_probing(struct inet_connection_sock *icsk, struct sock *sk) 
			struct tcp_sock *tp = tcp_sk(sk);

			int mss;



			mss = tcp_mtu_to_mss(sk, icsk->icsk_mtup.search_low)/2;

			mss = tcp_mtu_to_mss(sk, icsk->icsk_mtup.search_low) >> 1;

			mss = min(sysctl_tcp_base_mss, mss);

			mss = max(mss, 68 - tp->tcp_header_len);

			icsk->icsk_mtup.search_low = tcp_mss_to_mtu(sk, mss);