Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de519881 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: xusbatm.c: move assignment out of if () block 



We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarFelipe Balbi <balbi@ti.com>
parent adde04c6

drivers/usb/atm/xusbatm.c

+4 −2
Original line number Diff line number Diff line
@@ -73,7 +73,8 @@ static int xusbatm_capture_intf(struct usbatm_data *usbatm, struct usb_device *u 
		usb_err(usbatm, "%s: failed to claim interface %2d (%d)!\n", __func__, ifnum, ret);

		return ret;

	}

	if ((ret = usb_set_interface(usb_dev, ifnum, altsetting))) {

	ret = usb_set_interface(usb_dev, ifnum, altsetting);

	if (ret) {

		usb_err(usbatm, "%s: altsetting %2d for interface %2d failed (%d)!\n", __func__, altsetting, ifnum, ret);

		return ret;

	}
@@ -128,7 +129,8 @@ static int xusbatm_bind(struct usbatm_data *usbatm, 
			rx_intf->altsetting->desc.bInterfaceNumber,

			tx_intf->altsetting->desc.bInterfaceNumber);



	if ((ret = xusbatm_capture_intf(usbatm, usb_dev, rx_intf, rx_alt, rx_intf != intf)))

	ret = xusbatm_capture_intf(usbatm, usb_dev, rx_intf, rx_alt, rx_intf != intf);

	if (ret)

		return ret;



	if ((tx_intf != rx_intf) && (ret = xusbatm_capture_intf(usbatm, usb_dev, tx_intf, tx_alt, tx_intf != intf))) {