Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit adde04c6 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: uss720.c: move assignment out of if () block 



We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarFelipe Balbi <balbi@ti.com>
parent 2fcdbdfd

drivers/usb/misc/uss720.c

+4 −2
Original line number Diff line number Diff line
@@ -714,7 +714,8 @@ static int uss720_probe(struct usb_interface *intf, 
	/*

	 * Allocate parport interface 

	 */

	if (!(priv = kzalloc(sizeof(struct parport_uss720_private), GFP_KERNEL))) {

	priv = kzalloc(sizeof(struct parport_uss720_private), GFP_KERNEL);

	if (!priv) {

		usb_put_dev(usbdev);

		return -ENOMEM;

	}
@@ -723,7 +724,8 @@ static int uss720_probe(struct usb_interface *intf, 
	kref_init(&priv->ref_count);

	spin_lock_init(&priv->asynclock);

	INIT_LIST_HEAD(&priv->asynclist);

	if (!(pp = parport_register_port(0, PARPORT_IRQ_NONE, PARPORT_DMA_NONE, &parport_uss720_ops))) {

	pp = parport_register_port(0, PARPORT_IRQ_NONE, PARPORT_DMA_NONE, &parport_uss720_ops);

	if (!pp) {

		printk(KERN_WARNING "uss720: could not register parport\n");

		goto probe_abort;

	}