Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc817987 authored by David Collins's avatar David Collins
Browse files

spmi: spmi-pmic-arb: check apid against limits before calling irq handler 



Check that the apid for an SPMI interrupt falls between the
min_apid and max_apid that can be handled by the APPS processor
before invoking the per-apid interrupt handler:
periph_interrupt().

This avoids an access violation in rare cases where the status
bit is set for an interrupt that is not owned by the APPS
processor.

Change-Id: Ib74cb4ae7be9849f0243659bb4c1435340e1e087
Signed-off-by: default avatarDavid Collins <collinsd@codeaurora.org>
parent ea5149e3

drivers/spmi/spmi-pmic-arb.c

+5 −0
Original line number Diff line number Diff line
@@ -584,6 +584,11 @@ static void __pmic_arb_chained_irq(struct spmi_pmic_arb *pa, bool show) 
			id = ffs(status) - 1;

			status &= ~BIT(id);

			apid = id + i * 32;

			if (apid < pa->min_apid || apid > pa->max_apid) {

				WARN_ONCE(true, "spurious spmi irq received for apid=%d\n",

					apid);

				continue;

			}

			enable = readl_relaxed(pa->intr +

					pa->ver_ops->acc_enable(apid));

			if (enable & SPMI_PIC_ACC_ENABLE_BIT)