Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db9bab54 authored by Ross Lagerwall's avatar Ross Lagerwall Committed by Greg Kroah-Hartman
Browse files

xen/pciback: Check dev_data before using it 



[ Upstream commit 1669907e3d1abfa3f7586e2d55dbbc117b5adba2 ]

If pcistub_init_device fails, the release function will be called with
dev_data set to NULL.  Check it before using it to avoid a NULL pointer
dereference.

Signed-off-by: default avatarRoss Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent deddbac9

drivers/xen/xen-pciback/pci_stub.c

+2 −1
Original line number Diff line number Diff line
@@ -106,7 +106,8 @@ static void pcistub_device_release(struct kref *kref) 
	 * is called from "unbind" which takes a device_lock mutex.

	 */

	__pci_reset_function_locked(dev);

	if (pci_load_and_free_saved_state(dev, &dev_data->pci_saved_state))

	if (dev_data &&

	    pci_load_and_free_saved_state(dev, &dev_data->pci_saved_state))

		dev_info(&dev->dev, "Could not reload PCI state\n");

	else

		pci_restore_state(dev);