Commit deddbac9 authored Nov 22, 2018 by Pan Bian Committed by Greg Kroah-Hartman Dec 05, 2019

HID: intel-ish-hid: fixes incorrect error handling



[ Upstream commit 6e0856d317440a950b17c00a9283114f025e5699 ]

The memory chunk allocated by hid_allocate_device() should be released
by hid_destroy_device(), not kfree().

Fixes: 0b28cb4b("HID: intel-ish-hid: ISH HID client driver")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 5cde122a

drivers/hid/intel-ish-hid/ishtp-hid.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -222,7 +222,7 @@ int ishtp_hid_probe(unsigned int cur_hid_dev,
		err_hid_device:
		kfree(hid_data);
		err_hid_data:
		kfree(hid);
		hid_destroy_device(hid);
		return rv;
		}