Commit d377167d authored Nov 03, 2020 by Zhang Qilong Committed by Greg Kroah-Hartman Dec 29, 2020

spi: tegra20-slink: fix reference leak in slink ops of tegra20



[ Upstream commit 763eab7074f6e71babd85d796156f05a675f9510 ]

pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in two callers(tegra_slink_setup and
tegra_slink_resume), so we should fix it.

Fixes: dc4dc360 ("spi: tegra: add spi driver for SLINK controller")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201103141345.6188-1-zhangqilong3@huawei.com


Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c6be4da5

drivers/spi/spi-tegra20-slink.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -761,6 +761,7 @@ static int tegra_slink_setup(struct spi_device *spi)

		ret = pm_runtime_get_sync(tspi->dev);
		if (ret < 0) {
		pm_runtime_put_noidle(tspi->dev);
		dev_err(tspi->dev, "pm runtime failed, e = %d\n", ret);
		return ret;
		}
		@@ -1197,6 +1198,7 @@ static int tegra_slink_resume(struct device *dev)

		ret = pm_runtime_get_sync(dev);
		if (ret < 0) {
		pm_runtime_put_noidle(dev);
		dev_err(dev, "pm runtime failed, e = %d\n", ret);
		return ret;
		}