Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6be4da5 authored by Zhang Qilong's avatar Zhang Qilong Committed by Greg Kroah-Hartman
Browse files

spi: spi-ti-qspi: fix reference leak in ti_qspi_setup 



[ Upstream commit 45c0cba753641e5d7c3207f04241bd0e7a021698 ]

pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in ti_qspi_setup, so we should fix it.

Fixes: 505a1495 ("spi/qspi: Add qspi flash controller")
Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201103140947.3815-1-zhangqilong3@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 7ce2c18e

drivers/spi/spi-ti-qspi.c

+1 −0
Original line number Diff line number Diff line
@@ -175,6 +175,7 @@ static int ti_qspi_setup(struct spi_device *spi) 


	ret = pm_runtime_get_sync(qspi->dev);

	if (ret < 0) {

		pm_runtime_put_noidle(qspi->dev);

		dev_err(qspi->dev, "pm_runtime_get_sync() failed\n");

		return ret;

	}