Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0d04b95 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Greg Kroah-Hartman
Browse files

memory: fsl_ifc: fix leak of IO mapping on probe failure 



[ Upstream commit 3b132ab67fc7a358fff35e808fa65d4bea452521 ]

On probe error the driver should unmap the IO memory.  Smatch reports:

  drivers/memory/fsl_ifc.c:298 fsl_ifc_ctrl_probe() warn: 'fsl_ifc_ctrl_dev->gregs' not released on lines: 298.

Fixes: a20cbdef ("powerpc/fsl: Add support for Integrated Flash Controller")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210527154322.81253-1-krzysztof.kozlowski@canonical.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 21badeb6

drivers/memory/fsl_ifc.c

+2 −2
Original line number Diff line number Diff line
@@ -231,8 +231,7 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev) 
	fsl_ifc_ctrl_dev->gregs = of_iomap(dev->dev.of_node, 0);

	if (!fsl_ifc_ctrl_dev->gregs) {

		dev_err(&dev->dev, "failed to get memory region\n");

		ret = -ENODEV;

		goto err;

		return -ENODEV;

	}



	if (of_property_read_bool(dev->dev.of_node, "little-endian")) {
@@ -308,6 +307,7 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev) 
	free_irq(fsl_ifc_ctrl_dev->irq, fsl_ifc_ctrl_dev);

	irq_dispose_mapping(fsl_ifc_ctrl_dev->irq);

err:

	iounmap(fsl_ifc_ctrl_dev->gregs);

	return ret;

}