Commit 21badeb6 authored Jun 07, 2021 by Philipp Zabel Committed by Greg Kroah-Hartman Jul 20, 2021

reset: bail if try_module_get() fails



[ Upstream commit 4fb26fb83f0def3d39c14e268bcd4003aae8fade ]

Abort instead of returning a new reset control for a reset controller
device that is going to have its module unloaded.

Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fixes: 61fc4131 ("reset: Add reset controller API")
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210607082615.15160-1-p.zabel@pengutronix.de


Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent d88da267

drivers/reset/core.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -263,7 +263,10 @@ static struct reset_control *__reset_control_get_internal(
		if (!rstc)
		return ERR_PTR(-ENOMEM);

		try_module_get(rcdev->owner);
		if (!try_module_get(rcdev->owner)) {
		kfree(rstc);
		return ERR_PTR(-ENODEV);
		}

		rstc->rcdev = rcdev;
		list_add(&rstc->list, &rcdev->reset_control_head);