Commit c238f9aa authored Jun 26, 2020 by Dan Carpenter Committed by Greg Kroah-Hartman Aug 21, 2020

drm/vmwgfx: Fix two list_for_each loop exit tests



[ Upstream commit 4437c1152ce0e57ab8f401aa696ea6291cc07ab1 ]

These if statements are supposed to be true if we ended the
list_for_each_entry() loops without hitting a break statement but they
don't work.

In the first loop, we increment "i" after the "if (i == unit)" condition
so we don't necessarily know that "i" is not equal to unit at the end of
the loop.

In the second loop we exit when mode is not pointing to a valid
drm_display_mode struct so it doesn't make sense to check "mode->type".

Fixes: a278724a ("drm/vmwgfx: Implement fbdev on kms v2")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Signed-off-by: Roland Scheidegger <sroland@vmware.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent ba25f41e

drivers/gpu/drm/vmwgfx/vmwgfx_kms.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -2109,7 +2109,7 @@ int vmw_kms_fbdev_init_data(struct vmw_private *dev_priv,
		++i;
		}

		if (i != unit) {
		if (&con->head == &dev_priv->dev->mode_config.connector_list) {
		DRM_ERROR("Could not find initial display unit.\n");
		return -EINVAL;
		}
		@@ -2131,13 +2131,13 @@ int vmw_kms_fbdev_init_data(struct vmw_private *dev_priv,
		break;
		}

		if (mode->type & DRM_MODE_TYPE_PREFERRED)
		*p_mode = mode;
		else {
		if (&mode->head == &con->modes) {
		WARN_ONCE(true, "Could not find initial preferred mode.\n");
		*p_mode = list_first_entry(&con->modes,
		struct drm_display_mode,
		head);
		} else {
		*p_mode = mode;
		}

		return 0;