Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba25f41e authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

Input: sentelic - fix error return when fsp_reg_write fails 



[ Upstream commit ea38f06e0291986eb93beb6d61fd413607a30ca4 ]

Currently when the call to fsp_reg_write fails -EIO is not being returned
because the count is being returned instead of the return value in retval.
Fix this by returning the value in retval instead of count.

Addresses-Coverity: ("Unused value")
Fixes: fc69f4a6 ("Input: add new driver for Sentelic Finger Sensing Pad")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200603141218.131663-1-colin.king@canonical.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d0883cb8

drivers/input/mouse/sentelic.c

+1 −1
Original line number Diff line number Diff line
@@ -454,7 +454,7 @@ static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data, 


	fsp_reg_write_enable(psmouse, false);



	return count;

	return retval;

}



PSMOUSE_DEFINE_WO_ATTR(setreg, S_IWUSR, NULL, fsp_attr_set_setreg);