Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c1dcb14e authored by Sergei Shtylyov's avatar Sergei Shtylyov Committed by Ralf Baechle
Browse files

[MIPS] Alchemy common code style cleanup



Fix many errors and warnings given by checkpatch.pl:

- use of C99 // comments;

- missing space between the type and asterisk in a variable declaration;

- space between the asterisk and function/variable name;

- leading spaces instead of tabs;

- space after opening and before closing parentheses;

- initialization of a 'static' variable to 0;

- missing spaces around assignement/comparison operator;

- brace not on the same line with condition (or 'else') in the 'if'/'switch'
  statement;

- missing space between 'if'/'for'/'while' and opening parenthesis;

- use of assignement in 'if' statement's condition;

- printk() without KERN_* facility level;

- EXPORT_SYMBOL() not following its function immediately;

- unnecessary braces for single-statement block;

- adding new 'typedef' (where including <linux/types.h> will do);

- use of 'extern' in the .c file (where it can be avoided by including header);

- line over 80 characters.

In addition to these changes, also do the following:

- insert missing space after opening brace and/or before closing brace in the
  structure initializers;

- insert spaces between operator and its operands;

- put the function's result type and name/parameters on the same line;

- properly indent multi-line expressions;

- remove commented out code;

- remove useless initializers and code;

- remove needless parentheses;

- fix broken/excess indentation;

- add missing spaces between operator and its operands;

- insert missing and remove excess new lines;

- group 'else' and 'if' together where possible;

- make au1xxx_platform_init() 'static';

- regroup variable declarations in pm_do_freq() for prettier look;

- replace numeric literals with the matching macros;

- fix printk() format specifiers mismatching the argument types;

- make the multi-line comment style consistent with the kernel style elsewhere
  by adding empty first line and/or adding space on their left side;

- make two-line comments that only have one line of text one-line;

- fix typos/errors, capitalize acronyms, etc. in the comments;

- fix/remove obsolete references in the comments;

- reformat some comments;

- add comment about the CPU:counter clock ratio to calc_clock();

- update MontaVista copyright;

- remove Pete Popov's and Steve Longerbeam's old email addresses...

Signed-off-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent ff6814d5
Loading
Loading
Loading
Loading
+3 −4
Original line number Diff line number Diff line
#
#  Copyright 2000 MontaVista Software Inc.
#  Author: MontaVista Software, Inc.
#     	ppopov@mvista.com or source@mvista.com
#  Copyright 2000, 2008 MontaVista Software Inc.
#  Author: MontaVista Software, Inc. <source@mvista.com>
#
# Makefile for the Alchemy Au1000 CPU, generic files.
# Makefile for the Alchemy Au1xx0 CPUs, generic files.
#

obj-y += prom.o irq.o puts.o time.o reset.o \
+72 −73
Original line number Diff line number Diff line
@@ -203,4 +203,3 @@ struct au1xxx_irqmap __initdata au1xxx_ic0_map[] = {
};

int __initdata au1xxx_ic0_nr_irqs = ARRAY_SIZE(au1xxx_ic0_map);
+10 −14
Original line number Diff line number Diff line
/*
 * BRIEF MODULE DESCRIPTION
 *	Simple Au1000 clocks routines.
 *	Simple Au1xx0 clocks routines.
 *
 * Copyright 2001 MontaVista Software Inc.
 * Author: MontaVista Software, Inc.
 *		ppopov@mvista.com or source@mvista.com
 * Copyright 2001, 2008 MontaVista Software Inc.
 * Author: MontaVista Software, Inc. <source@mvista.com>
 *
 *  This program is free software; you can redistribute	 it and/or modify it
 *  under  the terms of	 the GNU General  Public License as published by the
@@ -30,8 +29,8 @@
#include <linux/module.h>
#include <asm/mach-au1x00/au1000.h>

static unsigned int au1x00_clock; // Hz
static unsigned int lcd_clock;    // KHz
static unsigned int au1x00_clock; /*  Hz */
static unsigned int lcd_clock;    /* KHz */
static unsigned long uart_baud_base;

/*
@@ -47,8 +46,6 @@ unsigned int get_au1x00_speed(void)
	return au1x00_clock;
}



/*
 * The UART baud base is not known at compile time ... if
 * we want to be able to use the same code on different
@@ -73,8 +70,7 @@ void set_au1x00_uart_baud_base(unsigned long new_baud_base)
void set_au1x00_lcd_clock(void)
{
	unsigned int static_cfg0;
	unsigned int sys_busclk =
		(get_au1x00_speed()/1000) /
	unsigned int sys_busclk = (get_au1x00_speed() / 1000) /
				  ((int)(au_readl(SYS_POWERCTRL) & 0x03) + 2);

	static_cfg0 = au_readl(MEM_STCFG0);
@@ -85,12 +81,12 @@ void set_au1x00_lcd_clock(void)
		lcd_clock = sys_busclk / 4;

	if (lcd_clock > 50000) /* Epson MAX */
		printk("warning: LCD clock too high (%d KHz)\n", lcd_clock);
		printk(KERN_WARNING "warning: LCD clock too high (%u KHz)\n",
				    lcd_clock);
}

unsigned int get_au1x00_lcd_clock(void)
{
	return lcd_clock;
}

EXPORT_SYMBOL(get_au1x00_lcd_clock);
+2 −3
Original line number Diff line number Diff line
@@ -39,8 +39,7 @@ struct cpu_spec cpu_specs[] = {
	{ 0x00000000, 0x00000000, "Unknown Au1xxx", 1, 0, 0 }
};

void
set_cpuspec(void)
void set_cpuspec(void)
{
	struct	cpu_spec *sp;
	u32	prid;
+184 −205

File changed.

Preview size limit exceeded, changes collapsed.

Loading