Commit b93a3553 authored Jan 18, 2012 by Michael S. Tsirkin Committed by Avi Kivity Mar 05, 2012

KVM: fix error handling for out of range irq



find_index_from_host_irq returns 0 on error
but callers assume < 0 on error. This should
not matter much: an out of range irq should never happen since
irq handler was registered with this irq #,
and even if it does we get a spurious msix irq in guest
and typically nothing terrible happens.

Still, better to make it consistent.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>

parent e2358851

virt/kvm/assigned-dev.c

+1 −3

Original line number	Original line	Diff line number	Diff line
	@@ -49,10 +49,8 @@ static int find_index_from_host_irq(struct kvm_assigned_dev_kernel
	index = i;		index = i;
	break;		break;
	}		}
	if (index < 0) {		if (index < 0)
	printk(KERN_WARNING "Fail to find correlated MSI-X entry!\n");		printk(KERN_WARNING "Fail to find correlated MSI-X entry!\n");
	return 0;
	}

	return index;		return index;
	}		}