Commit a1c173da authored Aug 05, 2015 by Jason Gerecke Committed by Jiri Kosina Aug 10, 2015

HID: wacom: Do not repeatedly attempt to set device mode on error



As an extension of aef3156d, there is no sense in repeatedly calling the
'wacom_set_report' and 'wacom_get_report' functions if they return an
error. Getting an error from them implies that the device is out to lunch:
either a hard error code was returned or repeated attempts at recovering
from a "soft" error all failed. In either case, doing even more retries is
not likely to resolve whatever is wrong.

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent ba532198

drivers/hid/wacom_sys.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -335,7 +335,7 @@ static int wacom_set_device_mode(struct hid_device *hdev, int report_id,
		if (error >= 0)
		error = wacom_get_report(hdev, HID_FEATURE_REPORT,
		rep_data, length, 1);
		} while ((error < 0 \|\| rep_data[1] != mode) && limit++ < WAC_MSG_RETRIES);
		} while (error >= 0 && rep_data[1] != mode && limit++ < WAC_MSG_RETRIES);

		kfree(rep_data);