Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f135787 authored by Wei Yongjun's avatar Wei Yongjun Committed by Mark Brown
Browse files

spi: s3c64xx: fix reference leak to master in s3c64xx_spi_remove() 



Once a spi_master_get() call succeeds, we need an additional
spi_master_put() call to free the memory, otherwise we will
leak a reference to master. Fix by removing the unnecessary
spi_master_get() call.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: default avatarAndi Shyti <andi.shyti@samsung.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d9aaf1dc

drivers/spi/spi-s3c64xx.c

+1 −1
Original line number Diff line number Diff line
@@ -1211,7 +1211,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) 


static int s3c64xx_spi_remove(struct platform_device *pdev)

{

	struct spi_master *master = spi_master_get(platform_get_drvdata(pdev));

	struct spi_master *master = platform_get_drvdata(pdev);

	struct s3c64xx_spi_driver_data *sdd = spi_master_get_devdata(master);



	pm_runtime_get_sync(&pdev->dev);