Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a23cf5b authored by Haibo Chen's avatar Haibo Chen Committed by Greg Kroah-Hartman
Browse files

iio: accel: mma8452: ignore the return value of reset operation 



commit bf745142cc0a3e1723f9207fb0c073c88464b7b4 upstream.

On fxls8471, after set the reset bit, the device will reset immediately,
will not give ACK. So ignore the return value of this reset operation,
let the following code logic to check whether the reset operation works.

Signed-off-by: default avatarHaibo Chen <haibo.chen@nxp.com>
Fixes: ecabae71 ("iio: mma8452: Initialise before activating")
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/1655292718-14287-1-git-send-email-haibo.chen@nxp.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0108c1ac

drivers/iio/accel/mma8452.c

+7 −3
Original line number Diff line number Diff line
@@ -1405,10 +1405,14 @@ static int mma8452_reset(struct i2c_client *client) 
	int i;

	int ret;



	ret = i2c_smbus_write_byte_data(client,	MMA8452_CTRL_REG2,

	/*

	 * Find on fxls8471, after config reset bit, it reset immediately,

	 * and will not give ACK, so here do not check the return value.

	 * The following code will read the reset register, and check whether

	 * this reset works.

	 */

	i2c_smbus_write_byte_data(client, MMA8452_CTRL_REG2,

					MMA8452_CTRL_REG2_RST);

	if (ret < 0)

		return ret;



	for (i = 0; i < 10; i++) {

		usleep_range(100, 200);