Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0108c1ac authored by Dmitry Rokosov's avatar Dmitry Rokosov Committed by Greg Kroah-Hartman
Browse files

iio:accel:bma180: rearrange iio trigger get and register 



commit e5f3205b04d7f95a2ef43bce4b454a7f264d6923 upstream.

IIO trigger interface function iio_trigger_get() should be called after
iio_trigger_register() (or its devm analogue) strictly, because of
iio_trigger_get() acquires module refcnt based on the trigger->owner
pointer, which is initialized inside iio_trigger_register() to
THIS_MODULE.
If this call order is wrong, the next iio_trigger_put() (from sysfs
callback or "delete module" path) will dereference "default" module
refcnt, which is incorrect behaviour.

Fixes: 0668a4e4 ("iio: accel: bma180: Fix indio_dev->trig assignment")
Signed-off-by: default avatarDmitry Rokosov <ddrokosov@sberdevices.ru>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20220524181150.9240-2-ddrokosov@sberdevices.ru


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 47014a0e

drivers/iio/accel/bma180.c

+2 −1
Original line number Diff line number Diff line
@@ -776,11 +776,12 @@ static int bma180_probe(struct i2c_client *client, 
		data->trig->dev.parent = &client->dev;

		data->trig->ops = &bma180_trigger_ops;

		iio_trigger_set_drvdata(data->trig, indio_dev);

		indio_dev->trig = iio_trigger_get(data->trig);



		ret = iio_trigger_register(data->trig);

		if (ret)

			goto err_trigger_free;



		indio_dev->trig = iio_trigger_get(data->trig);

	}



	ret = iio_triggered_buffer_setup(indio_dev, NULL,