Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98e2eeb3 authored by Andy Grover's avatar Andy Grover Committed by Nicholas Bellinger
Browse files

target/iscsi: Remove chap_set_random() 



The result from get_random_bytes should already be random, so further
manipulation and mixing should not be needed.

Signed-off-by: default avatarAndy Grover <agrover@redhat.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 30f359a6

drivers/target/iscsi/iscsi_target_auth.c

+1 −27
Original line number Diff line number Diff line
@@ -49,32 +49,6 @@ static void chap_binaryhex_to_asciihex(char *dst, char *src, int src_len) 
	}

}



static void chap_set_random(char *data, int length)

{

	long r;

	unsigned n;



	while (length > 0) {

		get_random_bytes(&r, sizeof(long));

		r = r ^ (r >> 8);

		r = r ^ (r >> 4);

		n = r & 0x7;



		get_random_bytes(&r, sizeof(long));

		r = r ^ (r >> 8);

		r = r ^ (r >> 5);

		n = (n << 3) | (r & 0x7);



		get_random_bytes(&r, sizeof(long));

		r = r ^ (r >> 8);

		r = r ^ (r >> 5);

		n = (n << 2) | (r & 0x3);



		*data++ = n;

		length--;

	}

}



static void chap_gen_challenge(

	struct iscsi_conn *conn,

	int caller,
@@ -86,7 +60,7 @@ static void chap_gen_challenge( 


	memset(challenge_asciihex, 0, CHAP_CHALLENGE_LENGTH * 2 + 1);



	chap_set_random(chap->challenge, CHAP_CHALLENGE_LENGTH);

	get_random_bytes(chap->challenge, CHAP_CHALLENGE_LENGTH);

	chap_binaryhex_to_asciihex(challenge_asciihex, chap->challenge,

				CHAP_CHALLENGE_LENGTH);

	/*