Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30f359a6 authored by Nicholas Bellinger's avatar Nicholas Bellinger
Browse files

target: Fix incorrect fallthrough of ALUA Standby/Offline/Transition CDBs 



This patch fixes a bug where a handful of informational / control CDBs
that should be allowed during ALUA access state Standby/Offline/Transition
where incorrectly returning CHECK_CONDITION + ASCQ_04H_ALUA_TG_PT_*.

This includes INQUIRY + REPORT_LUNS, which would end up preventing LUN
registration when LUN scanning occured during these ALUA access states.

Cc: Hannes Reinecke <hare@suse.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 055f648c

drivers/target/target_core_alua.c

+3 −0
Original line number Diff line number Diff line
@@ -409,6 +409,7 @@ static inline int core_alua_state_standby( 
	case REPORT_LUNS:

	case RECEIVE_DIAGNOSTIC:

	case SEND_DIAGNOSTIC:

		return 0;

	case MAINTENANCE_IN:

		switch (cdb[1] & 0x1f) {

		case MI_REPORT_TARGET_PGS:
@@ -451,6 +452,7 @@ static inline int core_alua_state_unavailable( 
	switch (cdb[0]) {

	case INQUIRY:

	case REPORT_LUNS:

		return 0;

	case MAINTENANCE_IN:

		switch (cdb[1] & 0x1f) {

		case MI_REPORT_TARGET_PGS:
@@ -491,6 +493,7 @@ static inline int core_alua_state_transition( 
	switch (cdb[0]) {

	case INQUIRY:

	case REPORT_LUNS:

		return 0;

	case MAINTENANCE_IN:

		switch (cdb[1] & 0x1f) {

		case MI_REPORT_TARGET_PGS: