Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9148b1aa authored by Vasily Averin's avatar Vasily Averin Committed by Greg Kroah-Hartman
Browse files

drm/qxl: qxl_release leak in qxl_hw_surface_alloc() 



commit a65aa9c3676ffccb21361d52fcfedd5b5ff387d7 upstream.

Cc: stable@vger.kernel.org
Fixes: 8002db63 ("qxl: convert qxl driver to proper use for reservations")
Signed-off-by: default avatarVasily Averin <vvs@virtuozzo.com>
Link: http://patchwork.freedesktop.org/patch/msgid/2e5a13ae-9ab2-5401-aa4d-03d5f5593423@virtuozzo.com


Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c1dcdab5

drivers/gpu/drm/qxl/qxl_cmd.c

+3 −2
Original line number Diff line number Diff line
@@ -500,9 +500,10 @@ int qxl_hw_surface_alloc(struct qxl_device *qdev, 
		return ret;



	ret = qxl_release_reserve_list(release, true);

	if (ret)

	if (ret) {

		qxl_release_free(qdev, release);

		return ret;



	}

	cmd = (struct qxl_surface_cmd *)qxl_release_map(qdev, release);

	cmd->type = QXL_SURFACE_CMD_CREATE;

	cmd->flags = QXL_SURF_FLAG_KEEP_DATA;