Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c1dcdab5 authored by Vasily Averin's avatar Vasily Averin Committed by Greg Kroah-Hartman
Browse files

drm/qxl: qxl_release leak in qxl_draw_dirty_fb() 



commit 85e9b88af1e6164f19ec71381efd5e2bcfc17620 upstream.

ret should be changed to release allocated struct qxl_release

Cc: stable@vger.kernel.org
Fixes: 8002db63 ("qxl: convert qxl driver to proper use for reservations")
Signed-off-by: default avatarVasily Averin <vvs@virtuozzo.com>
Link: http://patchwork.freedesktop.org/patch/msgid/22cfd55f-07c8-95d0-a2f7-191b7153c3d4@virtuozzo.com


Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9669600d

drivers/gpu/drm/qxl/qxl_draw.c

+3 −2
Original line number Diff line number Diff line
@@ -348,9 +348,10 @@ void qxl_draw_dirty_fb(struct qxl_device *qdev, 
		goto out_release_backoff;



	rects = drawable_set_clipping(qdev, num_clips, clips_bo);

	if (!rects)

	if (!rects) {

		ret = -EINVAL;

		goto out_release_backoff;



	}

	drawable = (struct qxl_drawable *)qxl_release_map(qdev, release);



	drawable->clip.type = SPICE_CLIP_TYPE_RECTS;