Commit 83e331e2 authored Sep 25, 2006 by Chuck Short Committed by David S. Miller Sep 28, 2006

[IRDA] via-ircc: fix memory leak

Fix memory leak.

Coverity id# 653

patch location:
http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=a1f34cb68b16807ed9d5ebb0f6a6ec5ff8a5fc78



Signed-off-by: Chuck Short <zulcss@gmail.com>
Signed-off-by: Ben Collins <bcollins@ubuntu.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 293b9c42

drivers/net/irda/via-ircc.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -1223,8 +1223,13 @@ static int upload_rxdata(struct via_ircc_cb *self, int iobase)

		IRDA_DEBUG(2, "%s(): len=%x\n", __FUNCTION__, len);

		if ((len - 4) < 2) {
		self->stats.rx_dropped++;
		return FALSE;
		}

		skb = dev_alloc_skb(len + 1);
		if ((skb == NULL) \|\| ((len - 4) < 2)) {
		if (skb == NULL) {
		self->stats.rx_dropped++;
		return FALSE;
		}