Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83454bf8 authored Mar 20, 2017 by Carter Cooper

msm: kgsl: Set a failed GMU register read to 0



Set the return variable to 0 instead of 0xDEADBEEF.
If the register read failed and the code then checks the
returned value against certain bits being set, it could
have false positives and perform the wrong actions.

Change-Id: I3f3a09f8b32ce9cf7b95378a4232d29aaa1629f8
Signed-off-by: Carter Cooper <ccooper@codeaurora.org>

parent afc85918

drivers/gpu/msm/adreno.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1232,7 +1232,7 @@ static inline void adreno_read_gmureg(struct adreno_device *adreno_dev,
	kgsl_gmu_regread(KGSL_DEVICE(adreno_dev),		kgsl_gmu_regread(KGSL_DEVICE(adreno_dev),
	gpudev->reg_offsets->offsets[offset_name], val);		gpudev->reg_offsets->offsets[offset_name], val);
	else		else
	*val = 0xDEADBEEF;		*val = 0;
	}		}

	/*		/*

drivers/gpu/msm/kgsl_device.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -548,7 +548,7 @@ static inline void kgsl_gmu_regread(struct kgsl_device *device,
	if (device->ftbl->gmu_regread)		if (device->ftbl->gmu_regread)
	device->ftbl->gmu_regread(device, offsetwords, value);		device->ftbl->gmu_regread(device, offsetwords, value);
	else		else
	*value = 0xDEADBEEF;		*value = 0;
	}		}

	static inline void kgsl_gmu_regwrite(struct kgsl_device *device,		static inline void kgsl_gmu_regwrite(struct kgsl_device *device,