Commit 7f6c7e62 authored Mar 06, 2012 by Miklos Szeredi Committed by Al Viro Mar 10, 2012

vfs: fix return value from do_last()



complete_walk() returns either ECHILD or ESTALE.  do_last() turns this into
ECHILD unconditionally.  If not in RCU mode, this error will reach userspace
which is complete nonsense.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 097b180c

fs/namei.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -2162,7 +2162,7 @@ static struct file do_last(struct nameidata nd, struct path *path,
	/* sayonara */		/* sayonara */
	error = complete_walk(nd);		error = complete_walk(nd);
	if (error)		if (error)
	return ERR_PTR(-ECHILD);		return ERR_PTR(error);

	error = -ENOTDIR;		error = -ENOTDIR;
	if (nd->flags & LOOKUP_DIRECTORY) {		if (nd->flags & LOOKUP_DIRECTORY) {