Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 097b180c authored by Miklos Szeredi's avatar Miklos Szeredi Committed by Al Viro
Browse files

vfs: fix double put after complete_walk() 



complete_walk() already puts nd->path, no need to do it again at cleanup time.

This would result in Oopses if triggered, apparently the codepath is not too
well exercised.

Signed-off-by: default avatarMiklos Szeredi <mszeredi@suse.cz>
CC: stable@vger.kernel.org
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent f6940fe9

fs/namei.c

+1 −1
Original line number Diff line number Diff line
@@ -2261,7 +2261,7 @@ static struct file *do_last(struct nameidata *nd, struct path *path, 
	/* Why this, you ask?  _Now_ we might have grown LOOKUP_JUMPED... */

	error = complete_walk(nd);

	if (error)

		goto exit;

		return ERR_PTR(error);

	error = -EISDIR;

	if (S_ISDIR(nd->inode->i_mode))

		goto exit;