Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 751ceca5 authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Greg Kroah-Hartman
Browse files

net: cxgb3_main: disable napi when bind qsets failed in cxgb_up() 



[ Upstream commit d75aed1428da787cbe42bc073d76f1354f364d92 ]

When failed to bind qsets in cxgb_up() for opening device, napi isn't
disabled. When open cxgb3 device next time, it will trigger a BUG_ON()
in napi_enable(). Compile tested only.

Fixes: 48c4b6db ("cxgb3 - fix port up/down error path")
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Link: https://lore.kernel.org/r/20221109021451.121490-1-shaozhengchao@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 2c674994

drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c

+1 −0
Original line number Diff line number Diff line
@@ -1304,6 +1304,7 @@ static int cxgb_up(struct adapter *adap) 
		if (ret < 0) {

			CH_ERR(adap, "failed to bind qsets, err %d\n", ret);

			t3_intr_disable(adap);

			quiesce_rx(adap);

			free_irq_resources(adap);

			err = ret;

			goto out;