Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c674994 authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Greg Kroah-Hartman
Browse files

drivers: net: xgene: disable napi when register irq failed in xgene_enet_open() 



[ Upstream commit ce9e57feeed81d17d5e80ed86f516ff0d39c3867 ]

When failed to register irq in xgene_enet_open() for opening device,
napi isn't disabled. When open xgene device next time, it will reports
a invalid opcode issue. Fix it. Only be compiled, not be tested.

Fixes: aeb20b6b ("drivers: net: xgene: fix: ifconfig up/down crash")
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Link: https://lore.kernel.org/r/20221107043032.357673-1-shaozhengchao@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 04f2cc56

drivers/net/ethernet/apm/xgene/xgene_enet_main.c

+3 −1
Original line number Diff line number Diff line
@@ -805,8 +805,10 @@ static int xgene_enet_open(struct net_device *ndev) 


	xgene_enet_napi_enable(pdata);

	ret = xgene_enet_register_irq(ndev);

	if (ret)

	if (ret) {

		xgene_enet_napi_disable(pdata);

		return ret;

	}



	if (ndev->phydev) {

		phy_start(ndev->phydev);