Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72a59786 authored by Tony Lindgren's avatar Tony Lindgren Committed by Greg Kroah-Hartman
Browse files

serial: 8250: omap: Flush PM QOS work on remove 



[ Upstream commit d0b68629bd2fb61e0171a62f2e8da3db322f5cf6 ]

Rebinding 8250_omap in a loop will at some point produce a warning for
kernel/power/qos.c:296 cpu_latency_qos_update_request() with error
"cpu_latency_qos_update_request called for unknown object". Let's flush
the possibly pending PM QOS work scheduled from omap8250_runtime_suspend()
before we disable runtime PM.

Fixes: 61929cf0 ("tty: serial: Add 8250-core based omap driver")
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20221028110044.54719-1-tony@atomide.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 222ab129

drivers/tty/serial/8250/8250_omap.c

+1 −0
Original line number Diff line number Diff line
@@ -1234,6 +1234,7 @@ static int omap8250_remove(struct platform_device *pdev) 


	pm_runtime_dont_use_autosuspend(&pdev->dev);

	pm_runtime_put_sync(&pdev->dev);

	flush_work(&priv->qos_work);

	pm_runtime_disable(&pdev->dev);

	serial8250_unregister_port(priv->line);

	pm_qos_remove_request(&priv->pm_qos_request);