Commit 222ab129 authored Oct 13, 2022 by Matthias Schiffer Committed by Greg Kroah-Hartman Nov 25, 2022

serial: 8250_omap: remove wait loop from Errata i202 workaround



[ Upstream commit e828e56684d61b17317e0cfdef83791fa61cb76b ]

We were occasionally seeing the "Errata i202: timedout" on an AM335x
board when repeatedly opening and closing a UART connected to an active
sender. As new input may arrive at any time, it is possible to miss the
"RX FIFO empty" condition, forcing the loop to wait until it times out.

Nothing in the i202 Advisory states that such a wait is even necessary;
other FIFO clear functions like serial8250_clear_fifos() do not wait
either. For this reason, it seems safe to remove the wait, fixing the
mentioned issue.

Fixes: 61929cf0 ("tty: serial: Add 8250-core based omap driver")
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Link: https://lore.kernel.org/r/20221013112339.2540767-1-matthias.schiffer@ew.tq-group.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 41fad4f7

drivers/tty/serial/8250/8250_omap.c

+0 −17

Original line number	Diff line number	Diff line
		@@ -160,27 +160,10 @@ static void omap8250_set_mctrl(struct uart_port *port, unsigned int mctrl)
		static void omap_8250_mdr1_errataset(struct uart_8250_port *up,
		struct omap8250_priv *priv)
		{
		u8 timeout = 255;

		serial_out(up, UART_OMAP_MDR1, priv->mdr1);
		udelay(2);
		serial_out(up, UART_FCR, up->fcr \| UART_FCR_CLEAR_XMIT \|
		UART_FCR_CLEAR_RCVR);
		/*
		* Wait for FIFO to empty: when empty, RX_FIFO_E bit is 0 and
		* TX_FIFO_E bit is 1.
		*/
		while (UART_LSR_THRE != (serial_in(up, UART_LSR) &
		(UART_LSR_THRE \| UART_LSR_DR))) {
		timeout--;
		if (!timeout) {
		/* Should never happen. we warn and carry on */
		dev_crit(up->port.dev, "Errata i202: timedout %x\n",
		serial_in(up, UART_LSR));
		break;
		}
		udelay(1);
		}
		}

		static void omap_8250_get_divisor(struct uart_port *port, unsigned int baud,