Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62ce7cd6 authored by Wei Yongjun's avatar Wei Yongjun Committed by Peter De Schrijver
Browse files

clk: tegra: fix __clk_lookup() return value checks 



In case of error, the function __clk_lookup() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarPeter De Schrijver <pdeschrijver@nvidia.com>
parent 8ba4b3b9

drivers/clk/tegra/clk-pll.c

+4 −4
Original line number Diff line number Diff line
@@ -1490,7 +1490,7 @@ struct clk *tegra_clk_register_pllxc(const char *name, const char *parent_name, 
	u32 val, val_iddq;



	parent = __clk_lookup(parent_name);

	if (IS_ERR(parent)) {

	if (!parent) {

		WARN(1, "parent clk %s of %s must be registered first\n",

			name, parent_name);

		return ERR_PTR(-EINVAL);
@@ -1591,7 +1591,7 @@ struct clk *tegra_clk_register_pllm(const char *name, const char *parent_name, 
		return ERR_PTR(-EINVAL);



	parent = __clk_lookup(parent_name);

	if (IS_ERR(parent)) {

	if (!parent) {

		WARN(1, "parent clk %s of %s must be registered first\n",

			name, parent_name);

		return ERR_PTR(-EINVAL);
@@ -1632,7 +1632,7 @@ struct clk *tegra_clk_register_pllc(const char *name, const char *parent_name, 
		return ERR_PTR(-EINVAL);



	parent = __clk_lookup(parent_name);

	if (IS_ERR(parent)) {

	if (!parent) {

		WARN(1, "parent clk %s of %s must be registered first\n",

			name, parent_name);

		return ERR_PTR(-EINVAL);
@@ -1756,7 +1756,7 @@ struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name, 
		return ERR_PTR(-EINVAL);



	parent = __clk_lookup(parent_name);

	if (IS_ERR(parent)) {

	if (!parent) {

		WARN(1, "parent clk %s of %s must be registered first\n",

			name, parent_name);

		return ERR_PTR(-EINVAL);