Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5edf1e06 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown
Browse files

ASoC: max98357a: use flags argument of devm_gpiod_get to set direction 



Since 39b2bbe3 (gpio: add flags argument to gpiod_get*() functions)
which appeared in v3.17-rc1, the gpiod_get* functions take an additional
parameter that allows to specify direction and initial value for output.

Use this to simplify the driver. Furthermore this is one caller less
that stops us making the flags argument to gpiod_get*() mandatory.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarKenneth Westfield <kwestfie@codeaurora.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1137e580

sound/soc/codecs/max98357a.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -60,13 +60,12 @@ static int max98357a_codec_probe(struct snd_soc_codec *codec) 
{

{

	struct gpio_desc *sdmode;

	struct gpio_desc *sdmode;





	sdmode = devm_gpiod_get(codec->dev, "sdmode");

	sdmode = devm_gpiod_get(codec->dev, "sdmode", GPIOD_OUT_LOW);

	if (IS_ERR(sdmode)) {

	if (IS_ERR(sdmode)) {

		dev_err(codec->dev, "%s() unable to get sdmode GPIO: %ld\n",

		dev_err(codec->dev, "%s() unable to get sdmode GPIO: %ld\n",

				__func__, PTR_ERR(sdmode));

				__func__, PTR_ERR(sdmode));

		return PTR_ERR(sdmode);

		return PTR_ERR(sdmode);

	}

	}

	gpiod_direction_output(sdmode, 0);

	snd_soc_codec_set_drvdata(codec, sdmode);

	snd_soc_codec_set_drvdata(codec, sdmode);





	return 0;

	return 0;