Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e44f8c3 authored by Hugh Dickins's avatar Hugh Dickins Committed by Theodore Ts'o
Browse files

ext4: hole-punch use truncate_pagecache_range



When truncating a file, we unmap pages from userspace first, as that's
usually more efficient than relying, page by page, on the fallback in
truncate_inode_page() - particularly if the file is mapped many times.

Do the same when punching a hole: 3.4 added truncate_pagecache_range()
to do the unmap and trunc, so use it in ext4_ext_punch_hole(), instead
of calling truncate_inode_pages_range() directly.

Signed-off-by: default avatarHugh Dickins <hughd@google.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent b2f4edb3
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -4789,7 +4789,7 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length)

	/* Now release the pages */
	if (last_page_offset > first_page_offset) {
		truncate_inode_pages_range(mapping, first_page_offset,
		truncate_pagecache_range(inode, first_page_offset,
					 last_page_offset - 1);
	}