Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c23dcf8 authored by Tyrel Datwyler's avatar Tyrel Datwyler Committed by Greg Kroah-Hartman
Browse files

powerpc/pseries: Fix parent_dn reference leak in add_dt_node() 



commit b537ca6fede69a281dc524983e5e633d79a10a08 upstream.

A reference to the parent device node is held by add_dt_node() for the
node to be added. If the call to dlpar_configure_connector() fails
add_dt_node() returns ENOENT and that reference is not freed.

Add a call to of_node_put(parent_dn) prior to bailing out after a
failed dlpar_configure_connector() call.

Fixes: 8d5ff320 ("powerpc/pseries: Make dlpar_configure_connector parent node aware")
Signed-off-by: default avatarTyrel Datwyler <tyreld@linux.vnet.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dda70d28

arch/powerpc/platforms/pseries/mobility.c

+3 −1
Original line number Diff line number Diff line
@@ -225,8 +225,10 @@ static int add_dt_node(__be32 parent_phandle, __be32 drc_index) 
		return -ENOENT;



	dn = dlpar_configure_connector(drc_index, parent_dn);

	if (!dn)

	if (!dn) {

		of_node_put(parent_dn);

		return -ENOENT;

	}



	rc = dlpar_attach_node(dn);

	if (rc)