Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 509e2412 authored by Veerabhadrarao Badiganti's avatar Veerabhadrarao Badiganti Committed by Sahitya Tummala
Browse files

mmc: host: cmdq: Check if tag info extraced from CQTERRI is valid



In the case of data errors (data CRC/timeout), we are extracting the
tag associated with the on-going command (in-case command is active)
instead of the tag associated with ongoing data. Which is wrong.
Updated the logic to use tag associated with data for data errors.

In some cases, CQTERRI is information is not reliable. So check if the
tag info provided by CQTERRI is valid or not. If not valid, complete
the errord request with any valid tag, so that all requests gets
requeued.

Without these above two check, we may use wrong tag (sometimes
completed tag, eg if CMD13 is going on CMD line, we have task field
as zero, it can be treated as tag-0 ) which can result in NULL pointer
dereferance issues.

Change-Id: Ia590e36d411975f383683a449892c71b51c1b882
Signed-off-by: default avatarVeerabhadrarao Badiganti <vbadigan@codeaurora.org>
Signed-off-by: default avatarSahitya Tummala <stummala@codeaurora.org>
parent b61e6dd3
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment