Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d3092fe authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Greg Kroah-Hartman
Browse files

RDMA/mlx4: Return missed an error if device doesn't support steering 

[ Upstream commit f4e56ec4452f48b8292dcf0e1c4bdac83506fb8b ]

The error flow fixed in this patch is not possible because all kernel
users of create QP interface check that device supports steering before
set IB_QP_CREATE_NETIF_QP flag.

Fixes: c1c98501 ("IB/mlx4: Add support for steerable IB UD QPs")
Link: https://lore.kernel.org/r/91c61f6e60eb0240f8bbc321fda7a1d2986dd03c.1634023677.git.leonro@nvidia.com


Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 09cc73bb

drivers/infiniband/hw/mlx4/qp.c

+3 −1
Original line number Diff line number Diff line
@@ -773,9 +773,11 @@ static int create_qp_common(struct mlx4_ib_dev *dev, struct ib_pd *pd, 
			if (dev->steering_support ==

			    MLX4_STEERING_MODE_DEVICE_MANAGED)

				qp->flags |= MLX4_IB_QP_NETIF;

			else

			else {

				err = -EINVAL;

				goto err;

			}

		}



		memcpy(&backup_cap, &init_attr->cap, sizeof(backup_cap));

		err = set_kernel_sq_size(dev, &init_attr->cap,